Skip to content

feat(build): choose the Windows signer from the environment and verify signatures after every signed build - #1239

Open
JamieRuderman wants to merge 8 commits into
mainfrom
chore/windows-signing-prep
Open

JamieRuderman wants to merge 8 commits into
mainfrom
chore/windows-signing-prep

Conversation

@JamieRuderman

@JamieRuderman JamieRuderman commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Preparation for moving Windows code signing from SSL.com to Microsoft Artifact Signing. Nothing changes for today's releases: with no AZURE_SIGN_* variables set, the build is configured exactly as before.

Changes

  • electron/electron-builder.config.js spreads package.json's build and chooses the Windows signer from the environment (electron/scripts/win-signing.js): SKIP_SIGNING=true drops the signing config entirely, AZURE_SIGN_* selects win.azureSignOptions and writes a two-entry publisher allow-list into app-update.yml, otherwise the SSL.com hook stays. A partial Azure configuration fails the build rather than falling back.
  • verify-win-installers.js also checks Authenticode signatures on a signed build: each installer and the five executables inside its payload must be valid, timestamped, and from the expected publisher, matched by electron-updater's own rule. One PowerShell call per installer.
  • Workflow: azure/login (OIDC through the signing environment, no client secret) replaces the CodeSignTool download when the Azure variables are set; the release job carries id-token: write.
  • windows-upgrade-recover.ps1 now matches the unquoted publisherName block that 3.13.4-era builds actually ship; the old pattern reported the block as still present and restored the backup.
  • RELEASE.md: new "Windows code signing" section.

Verified

  • Unsigned branch build on the Windows runner with the new config: three installers built, payload verification passed, manifests generated (run).
  • All three generated configs validate against electron-builder's schema; electron tests pass (70).
  • The signature check ran on a Windows runner against the published, SSL.com-signed 3.48.10 installers (throwaway run, branch since deleted): all 18 signatures verified under SSL.com mode and under Azure mode with the legacy entry; with no matching publisher it failed with exit 1 naming the signer under Azure, and produced warnings only with exit 0 under SSL.com.
  • Under SSL.com, signature findings are ::warning:: annotations rather than failures, so a misfire can never force a paid re-sign; under Azure they fail the build.

Not in this PR

Setting the Azure variables and secrets, which is gated on the Azure account and the certificate subject. The switch itself is a repository-settings change once those exist.

@JamieRuderman

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 351ba5fb26

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aws-amplify-us-west-1

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1239.d20k671nqqv4kl.amplifyapp.com

@JamieRuderman

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 026ef94e48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@JamieRuderman

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 152f15579f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/build-electron.yml Resolved
Comment thread electron/scripts/win-signing.js Resolved
…ment and verify Azure builds against the Azure publisher alone
@JamieRuderman JamieRuderman changed the title feat(build): choose the Windows signer from the environment and verify signatures after every signed build feat(build): choose the Windows signer from the environment and verify signatures after every signed build. Nov 16, 2026
@JamieRuderman JamieRuderman changed the title feat(build): choose the Windows signer from the environment and verify signatures after every signed build. feat(build): choose the Windows signer from the environment and verify signatures after every signed build Nov 16, 2026
@JamieRuderman JamieRuderman reopened this Nov 16, 2026
@JamieRuderman JamieRuderman changed the title feat(build): choose the Windows signer from the environment and verify signatures after every signed build feat(build): choose the Windows signer from the environment and verify signatures after every signed build. Nov 16, 2026
@JamieRuderman JamieRuderman changed the title feat(build): choose the Windows signer from the environment and verify signatures after every signed build. feat(build): choose the Windows signer from the environment and verify signatures after every signed build Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant