Repository navigation
feat(build): choose the Windows signer from the environment and verify signatures after every signed build - #1239
JamieRuderman wants to merge 8 commits into
Conversation
…y every signature after the build
…unsigned builds and skip signing checks on a broken payload
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…rce them only under Azure signing
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 026ef94e48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…med files cannot shadow each other
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 152f15579f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ment and verify Azure builds against the Azure publisher alone
Preparation for moving Windows code signing from SSL.com to Microsoft Artifact Signing. Nothing changes for today's releases: with no
AZURE_SIGN_*variables set, the build is configured exactly as before.Changes
electron/electron-builder.config.jsspreads package.json'sbuildand chooses the Windows signer from the environment (electron/scripts/win-signing.js):SKIP_SIGNING=truedrops the signing config entirely,AZURE_SIGN_*selectswin.azureSignOptionsand writes a two-entry publisher allow-list intoapp-update.yml, otherwise the SSL.com hook stays. A partial Azure configuration fails the build rather than falling back.verify-win-installers.jsalso checks Authenticode signatures on a signed build: each installer and the five executables inside its payload must be valid, timestamped, and from the expected publisher, matched by electron-updater's own rule. One PowerShell call per installer.azure/login(OIDC through thesigningenvironment, no client secret) replaces the CodeSignTool download when the Azure variables are set; thereleasejob carriesid-token: write.windows-upgrade-recover.ps1now matches the unquotedpublisherNameblock that 3.13.4-era builds actually ship; the old pattern reported the block as still present and restored the backup.Verified
::warning::annotations rather than failures, so a misfire can never force a paid re-sign; under Azure they fail the build.Not in this PR
Setting the Azure variables and secrets, which is gated on the Azure account and the certificate subject. The switch itself is a repository-settings change once those exist.